Zachmu/datefns #74
Merged
Zachmu/datefns #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Musgrave <zach@liquidata.co>
Signed-off-by: Zach Musgrave <zach@liquidata.co>
Signed-off-by: Zach Musgrave <zach@liquidata.co>
Hydrocharged
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
It all looks good to me, but should we even have a convenient TIMESTAMP function? The range on a TIMESTAMP is so small that it seems like an overall useless type nowadays (was probably before DATETIME was added), and providing a convenient shortcut function for it could push people to use it. In 19 years, TIMESTAMP() will always fail because NOW() will always be out of range.
Just a thought though, nothing too big 😃
Signed-off-by: Zach Musgrave <zach@liquidata.co>
… calls) Signed-off-by: Zach Musgrave <zach@liquidata.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for DATETIME() and TIMESTAMP() functions