Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added password validation for logging in #745

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

Hydrocharged
Copy link
Contributor

Now when creating a user, you can specify a password and log in according to the password given. Denies all incorrect password or invalid users. Also added a killswitch in the grant tables to disable this functionality since it's not yet ready.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but this is now passing the point where it leaves dolt compatibility behind. Need to fix that before merging this to main. Maybe a way to initialize grant table contents with a single user and pass, like Dolt currently uses?

enginetest/memory_engine_test.go Show resolved Hide resolved
sql/grant_tables/grant_tables.go Show resolved Hide resolved
sql/grant_tables/grant_tables.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants