ctx in Session.Set #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2020 19:20
Signed-off-by: Brian Hendriks <brian@liquidata.co>
bheni
force-pushed
the
bh/ctx-in-session-set
branch
from
77a497a
to
394f4f6
Compare
zachmu
approved these changes
Apr 17, 2020
| @@ -88,10 +88,11 @@ func (s *BaseSession) Address() string { return s.addr } | |||
| func (s *BaseSession) Client() Client { return s.client } | |||
|
|
|||
| // Set implements the Session interface. | |||
| func (s *BaseSession) Set(key string, typ Type, value interface{}) { | |||
| func (s *BaseSession) Set(ctx context.Context, key string, typ Type, value interface{}) error { | |||
There was a problem hiding this comment.
This would create a weird circular reference that I don't really like.
|
I'm merging this because you already merged changes in dolt that rely on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.