Auto Increment Refactor #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Mar 24, 2022
| @@ -492,20 +492,23 @@ func rowsAreEqual(ctx *sql.Context, schema sql.Schema, left, right sql.Row) (boo | |||
| } | |||
|
|
|||
| // PeekNextAutoIncrementValue peeks at the next AUTO_INCREMENT value | |||
| func (t *Table) PeekNextAutoIncrementValue(*sql.Context) (interface{}, error) { | |||
There was a problem hiding this comment.
Problem is this could be a float. If you go this route you need affordances for that
| } | ||
|
|
||
| return next, nil |
There was a problem hiding this comment.
Seems like this is probably enough to handle float columns, but make sure there are tests
| @@ -810,7 +809,7 @@ func tablesRowIter(ctx *Context, cat Catalog) (RowIter, error) { | |||
| nil, // max_data_length | |||
| nil, // max_data_length | |||
| nil, // data_free | |||
| autoVal, // auto_increment | |||
| nil, // auto_increment (always nil) | |||
There was a problem hiding this comment.
This isn't right, MySQL definitely returns accurate info for this. Why do we need to get rid of it?
There was a problem hiding this comment.
mysql always returns NULL for user space tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.