Secondary Indexes #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Apr 21, 2020
There was a problem hiding this comment.
So the overall interface and implementation look good, with one major exception: I don't think we should abandon the pilosa index driver implementation yet. You should keep the existing index creation code around, and trigger it (via a different kind of plan node) based on a USING clause that isn't btree or hash. We might rip it out eventually, but if we are going to hard fork this project we do need to keep support for pilosa, at least in the short term.
Hydrocharged
force-pushed
the
daylon/indexes
branch
2 times, most recently
from
65c8f2c
to
a7094b7
Compare
zachmu
approved these changes
Apr 23, 2020
Signed-off-by: Daylon Wilkins <daylon@liquidata.co>
Hydrocharged
force-pushed
the
daylon/indexes
branch
from
a7094b7
to
732cd8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been cleaned up and whatnot, so you can give this an earnest look. Most things are a deletion, since I chose to go about things a bit differently than it was already coded in, but overall there are relatively few new additions. I also removed a lot of the temporary code that was hanging around, as it turns out most of it wasn't needed.