Fix underspecified insert tests #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Apr 21, 2022
| return n, transform.SameTree, nil | ||
| } | ||
|
|
||
| if _, ok := ins.Source.(*plan.TriggerExecutor); ok { |
There was a problem hiding this comment.
So we don't do this if there's a pre-insert trigger? Why? Leave a comment
There was a problem hiding this comment.
i'll copy the comment from above
| if _, ok := parsed.(sql.Databaser); ok { | ||
| _, isInsert := parsed.(*plan.InsertInto) | ||
| _, isDatabaser := parsed.(sql.Databaser) | ||
| if bl, ok := parsed.(*plan.Block); ok { |
There was a problem hiding this comment.
When is an insert ever inside a block node? What's going on here?
There was a problem hiding this comment.
this one also confuses me, daylon added Block last week for foreign keys
There was a problem hiding this comment.
looks like *sqlparser.MultiAlterDDL is now a thing, Block wraps arbitrarily nested statements?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No inserts were not being run with prepareds. A lot of them were broken, but should be running in GMS now at least.
Edit: These pass Dolt also.