Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support more than 1 byte characters to insert for char()/varchar() types #964

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

jennifersp
Copy link
Contributor

Allows inserting strings with 'exact number of character but consists of more bytes' values to char() or varchar() types
Fixes dolthub/dolt#3233

@jennifersp jennifersp changed the title support more than 1 byte characters to insert support more than 1 byte characters to insert for char()/varchar() types Apr 20, 2022
Copy link
Contributor

@VinaiRachakonda VinaiRachakonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennifersp jennifersp merged commit 65a7b94 into main Apr 22, 2022
@jennifersp jennifersp deleted the jennifer/len branch April 22, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

character length of varchar values are calculated incorrectly for some characters
2 participants