Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Error Message for Inserting Strings that are too Long #969

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Improving Error Message for Inserting Strings that are too Long #969

merged 4 commits into from
Apr 21, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Apr 21, 2022 •
edited

includes the string that failed and for which column

helps for: dolthub/dolt#3270

zachmu
zachmu reviewed Apr 21, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test plz

Looks good otherwise

@jycor jycor changed the title Adding an error wrapper for ErrLengthBeyondLimit Improving Error Message for Inserting Strings that are too Long Apr 21, 2022
zachmu
zachmu approved these changes Apr 21, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@jycor jycor merged commit ab77125 into main Apr 21, 2022
@Hydrocharged Hydrocharged deleted the james/trigger-branch branch October 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jycor @zachmu