Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing return types for spatial functions #975

Merged
merged 9 commits into from
Apr 25, 2022
Merged

Fixing return types for spatial functions #975

merged 9 commits into from
Apr 25, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Apr 22, 2022 •
edited

Fix for: dolthub/dolt#3279

Adding tests that check the return type for functions

  • st_asgeojson
  • st_aswkb
  • st_aswkt
  • st_astext
  • st_dimension
  • st_latitude
  • st_longitude
  • st_swapxy
  • st_x
  • st_y

zachmu
zachmu reviewed Apr 22, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all of these, you want to run Eval on them too, see what actual value gets returned

The Type() should agree with that

@jycor jycor requested a review from zachmu April 22, 2022 23:35
zachmu
zachmu approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jycor jycor merged commit 4b6e2f6 into main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachmu zachmu zachmu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jycor @zachmu