Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move CURRENT to non-reserved-keyword-list #154

Merged
merged 2 commits into from Apr 20, 2022
Merged

move CURRENT to non-reserved-keyword-list #154

merged 2 commits into from Apr 20, 2022

Conversation

jennifersp
Copy link

@jennifersp jennifersp commented Apr 14, 2022 •
edited

CURRENT is non reserved keyword, it fixes issue of SELECT * FROM current query failing
Fixes dolthub/dolt#3224

@jennifersp jennifersp requested a review from zachmu as a code owner April 14, 2022 18:08
VinaiRachakonda
VinaiRachakonda approved these changes Apr 20, 2022
View reviewed changes
Copy link

@VinaiRachakonda VinaiRachakonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would like to see one or two tests with current as an alias or something.

@jennifersp jennifersp merged commit fd55765 into main Apr 20, 2022
@jennifersp jennifersp deleted the jennifer/current branch September 28, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinaiRachakonda VinaiRachakonda VinaiRachakonda approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting a view named current errors
2 participants
@jennifersp @VinaiRachakonda