adding support for PARTITION syntax for table creation
#193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
approved these changes
Sep 26, 2022
| } | ||
|
|
||
| any_keyword: | ||
| ID |
There was a problem hiding this comment.
ID doesn't belong here, it's not a keyword
There was a problem hiding this comment.
renamed to be any_identifier instead
| { | ||
| $$ = $2 | ||
| $$.Options = $4 | ||
| $$.Options = $4 + $5 |
There was a problem hiding this comment.
Adding a space here makes it so that tests that don't have a partition option have a dangling space afterwards, which causes a bunch of test failures.
I could add another member variable PartitionOptions to separate the two, and make the Format() output look better.
I don't think this matters too much though, since we're not using Options anywhere outside of just testing
|
|
||
| // partition options | ||
| { | ||
| input: "create table t (\n" + |
There was a problem hiding this comment.
Need some tests that combine partitions with other table options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing
table_optionsfor statements likeCREATE TABLE (column_definitions) table_optionsbetter matches MySQLCan parse
partition_optionsbased off of https://dev.mysql.com/doc/refman/8.0/en/create-table.htmlFix for: dolthub/dolt#4358