Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support explaining tables, and adding extended keyword #202

Merged
merged 2 commits into from
Nov 23, 2022
Merged

support explaining tables, and adding extended keyword #202

merged 2 commits into from
Nov 23, 2022

Conversation

jycor
Copy link

@jycor jycor commented Nov 23, 2022 •
edited
Loading

Even though it is deprecated, we can support EXPLAIN EXTENDED, since it does the same thing as normal EXPLAIN
https://dev.mysql.com/doc/refman/5.7/en/explain.html#:~:text=In%20older%20MySQL%20releases%2C%20extended%20information%20was%20produced%20using%20EXPLAIN%20EXTENDED.

Additionally, EXPLAIN, DESCRIBE, and DESC are all interchangable, so we should be able to EXPLAIN tbl

Fix for: dolthub/dolt#4185

@jycor jycor requested a review from zachmu as a code owner November 23, 2022 00:48
fulghum
fulghum approved these changes Nov 23, 2022
View reviewed changes
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice work! ⚡

@jycor jycor merged commit fcbc3dc into main Nov 23, 2022
@Hydrocharged Hydrocharged deleted the james/explain branch February 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jycor @fulghum