Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding parser support for show databases like and where #204

Merged
merged 1 commit into from
Dec 1, 2022
Merged

adding parser support for show databases like and where #204

merged 1 commit into from
Dec 1, 2022

Conversation

jycor
Copy link

@jycor jycor commented Dec 1, 2022

partial fix for: dolthub/dolt#4484

@jycor jycor requested a review from zachmu as a code owner December 1, 2022 20:22
@jycor jycor mentioned this pull request Dec 1, 2022
Merged
fulghum
fulghum approved these changes Dec 1, 2022
View reviewed changes
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚢

Seems like there's some flakiness with that TestTLSRequired test; I reran it and it passed this time. Certainly not related to your change though.

@jycor jycor merged commit 2fc2edc into main Dec 1, 2022
@Hydrocharged Hydrocharged deleted the james/databases branch February 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jycor @fulghum