Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing support for collations as strings #251

Merged
merged 1 commit into from Jun 22, 2023

Conversation

Hydrocharged
Copy link

Fixes issue dolthub/dolt#6192
We only allowed collations to be declared after the CREATE TABLE portion in their non-string form. This adds support for the string form.

@Hydrocharged Hydrocharged removed the request for review from zachmu June 22, 2023 10:57
@Hydrocharged Hydrocharged linked an issue Jun 22, 2023 that may be closed by this pull request
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change! 🚢

@Hydrocharged Hydrocharged merged commit 39f2d14 into main Jun 22, 2023
4 checks passed
@Hydrocharged Hydrocharged deleted the daylon/fix-collate-string branch June 22, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dolt does not allow strings as collate name
2 participants