Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed keyword usage in primary key clauses #252

Merged
merged 3 commits into from Jul 6, 2023
Merged

Fixed keyword usage in primary key clauses #252

merged 3 commits into from Jul 6, 2023

Conversation

zachmu
Copy link
Member

@zachmu zachmu commented Jul 6, 2023 •
edited

@zachmu zachmu requested a review from jycor July 6, 2023 20:50
jycor
jycor reviewed Jul 6, 2023
View reviewed changes
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
jycor
jycor approved these changes Jul 6, 2023
View reviewed changes
Copy link

@jycor jycor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit d13c7c2 into main Jul 6, 2023
4 checks passed
@Hydrocharged Hydrocharged deleted the zachmu/password branch February 7, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jycor jycor jycor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

primary key (password) requires password to be backticked
2 participants
@zachmu @jycor