Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for round tripping parsed cast function calls #259

Merged
merged 1 commit into from Jul 26, 2023
Merged

Conversation

fulghum
Copy link

@fulghum fulghum commented Jul 26, 2023

When formatting a parsed cast node back into a SQL string, we were using the form CAST(<arg>, <arg>), but that won't roundtrip back to MySQL. It needs to be either CONVERT(<arg>, <arg>) or CAST(<arg> as <arg).

@fulghum fulghum requested a review from zachmu as a code owner July 26, 2023 00:51
@fulghum fulghum merged commit 8af8467 into main Jul 26, 2023
4 checks passed
@Hydrocharged Hydrocharged deleted the fulghum/parser branch February 7, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants