Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support binary charset in table option #315

Merged
merged 3 commits into from Mar 7, 2024
Merged

support binary charset in table option #315

merged 3 commits into from Mar 7, 2024

Conversation

jycor
Copy link

@jycor jycor commented Mar 7, 2024 •
edited

This PR adds binary as a valid charset option.
Additionally, this changes CHARSET to expand to synonym CHARACTER SET for parsing in GMS.

fixes dolthub/dolt#7576

@jycor jycor requested a review from zachmu as a code owner March 7, 2024 07:29
@jycor jycor mentioned this pull request Mar 7, 2024
Merged
@jycor jycor requested a review from fulghum March 7, 2024 08:35
fulghum
fulghum approved these changes Mar 7, 2024
View reviewed changes
Copy link

@fulghum fulghum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fulghum fulghum merged commit 5f7f589 into main Mar 7, 2024
4 checks passed
@jycor jycor deleted the james/binary branch March 7, 2024 22:03
This was referenced Mar 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulghum fulghum fulghum approved these changes

@zachmu zachmu Awaiting requested review from zachmu zachmu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

default charset=binary is messing up in a create table statement
2 participants
@jycor @fulghum