Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to binlog event creation functions #329

Merged
merged 2 commits into from Apr 4, 2024

Conversation

fulghum
Copy link

@fulghum fulghum commented Apr 3, 2024

  • Exposing the Length() function in the BinlogEvent interface so calling code can access the event size present in a binlog event's header. Needed for calculating binlog file position.
  • Renaming FakeBinlogStreamBinlogStream so calling code can use it when serializing binlog events.

@fulghum fulghum requested a review from zachmu as a code owner April 3, 2024 23:42
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fulghum fulghum merged commit c5a87fc into main Apr 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants