allow backticks in system and user variables #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulghum
approved these changes
Jun 13, 2024
go/vt/sqlparser/parse_test.go
Outdated
| }, | ||
| { | ||
| input: "select @`user var`", | ||
| output: "select `@``user var```", |
There was a problem hiding this comment.
I didn't understand the quoting in the output string here. Why does the @ get backtick quoted and why is there an extra "``" at the end of the statement? Seems like this output isn't valid MySQL SQL either.
There was a problem hiding this comment.
I did some digging and this comes from some weirdness in the formatID method in ast.go; the function didn't properly handle escaping user variables.
I fixed the function to do it better, but it shouldn't have any impact on what GMS sees.
go/vt/sqlparser/token.go
Outdated
| @@ -428,10 +428,25 @@ func (tkn *Tokenizer) scanIdentifier(firstByte byte, isDbSystemVariable bool) (i | |||
| buffer.WriteByte(byte(tkn.lastChar)) | |||
| tkn.next() | |||
| } | |||
| for isLetter(tkn.lastChar) || isDigit(tkn.lastChar) || (isDbSystemVariable && isCarat(tkn.lastChar)) { | |||
| for isLetter(tkn.lastChar) || isDigit(tkn.lastChar) || (isDbSystemVariable && isCarat(tkn.lastChar)) /*|| (firstByte == '@' && isCarat(tkn.lastChar))*/ { | |||
There was a problem hiding this comment.
Take out this commented out condition?
added 2 commits
June 13, 2024 11:34
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the use of backticks in system and user variables.
We are more lenient than MySQL when it comes to backticks in set statements.
For example, we allow
set @abc.def= 10, while MySQL throws an error.This is because we treat this as a qualified column identifer and automatically strip the backticks.
test bump dolthub/go-mysql-server#2548
fixes dolthub/dolt#8010