Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/mysql/conn.go: Add a way to disable client_multi_statements handling on a per-connection basis. #93

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

reltuk
Copy link

@reltuk reltuk commented Dec 1, 2021

Conn's handling of CLIENT_MULTI_STATEMENTS is currently wrong for packets that
contain statements which can include other statements (e.g., CREATE TRIGGER).
Add a way for an integrator to disable it for now.

…ng on a per-connection basis.

Conn's handling of CLIENT_MULTI_STATEMENTS is currently wrong for packets that
contain statements which can include other statements (e.g., CREATE TRIGGER).
Add a way for an integrator to disable it for now.
@reltuk reltuk requested a review from zachmu as a code owner December 1, 2021 21:39
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reltuk reltuk merged commit 9e2dfe9 into main Dec 1, 2021
@Hydrocharged Hydrocharged deleted the aaron/mysql-conn-disable-multi-statements branch October 13, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants