Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open PDFs within browser window/lightbox #53

Closed
nielll opened this issue Dec 2, 2019 · 1 comment
Closed

Open PDFs within browser window/lightbox #53

nielll opened this issue Dec 2, 2019 · 1 comment
Assignees
@dom111
Labels
enhancement

Comments

@nielll
Copy link

nielll commented Dec 2, 2019

Hi Dom,

I just discovered another little detail to improve: When you click a pdf it directly downloads it instead of trying to open it in browser.
@nielll nielll changed the title show pdf in browser instead of downloading little improvements Dec 2, 2019
This was referenced Dec 2, 2019
Closed
Closed
@dom111 dom111 changed the title little improvements Open PDFs within browser window/lightbox Dec 2, 2019
@dom111
Copy link
Owner

dom111 commented Dec 2, 2019

Hey @nielll, I hope you don't mind, but I've split this out into separate issues!

@dom111 dom111 self-assigned this Dec 2, 2019
Repository owner deleted a comment from nielll May 5, 2020
Repository owner deleted a comment from nielll May 5, 2020
@dom111 dom111 closed this as completed in 47ffee7 May 5, 2020
dom111 added a commit that referenced this issue May 5, 2020
@dom111
Merge pull request #64 from dom111/feature/support-pdf-preview
07a7e01 
Add `<iframe>` preview support for PDF files. Closes #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dom111 dom111

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dom111 @nielll