Multiple fixes #156
Merged
Multiple fixes #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dom96
approved these changes
Jan 10, 2020
src/choosenim/builder.nim
Outdated
| if kind == pcFile: | ||
| # Set to 755 = rwxrw-rw- in octal | ||
| # = 493 in decimal | ||
| discard chmod(path, 493) |
There was a problem hiding this comment.
You shouldn't need posix for this, can you just use the os module?
dom96
approved these changes
Jan 11, 2020
Comment on lines
+77
to
+88
| when defined(posix): | ||
| proc setPermissions() = | ||
| ## Assumes that CWD contains the compiler | ||
| let binDir = getCurrentDir() / "bin" | ||
| for kind, path in walkDir(binDir): | ||
| if kind == pcFile: | ||
| setFilePermissions(path, | ||
| {fpUserRead, fpUserWrite, fpUserExec, | ||
| fpGroupRead, fpGroupExec, | ||
| fpOthersRead, fpOthersExec} | ||
| ) | ||
|
|
There was a problem hiding this comment.
Another thing that would be nice would be a debug output to say that these file permission changes are taking place. But I'll leave that to another PR if you agree that it's a good idea.
There was a problem hiding this comment.
To do that, we will have to first check the extracted permissions. Do you want to add that additional code?
There was a problem hiding this comment.
Huh? Just show the message always, even if the permissions aren't being changed. It'll be hidden anyway most of the time.
There was a problem hiding this comment.
Done in PR #158.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #147 - workaround rather since we don't have root cause yet
Fix #151 - correct binary names in CI
Add testament to list of proxies