Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support #282

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Add FreeBSD support #282

merged 1 commit into from
Dec 7, 2021

Conversation

lbartoletti
Copy link
Contributor

This line allows us to build and use choosenim on FreeBSD.

Previously this error was raised:

/tmp/nimble_50804/githubcom_dom96choosenim/src/choosenimpkg/utils.nim(167, 5) Error: expression '' has no type (or is ambiguous)

Copy link
Owner

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem I think we'll have is that we'd need to build choosenim for FreeBSD. I guess some might want to build it themselves anyway.

@lbartoletti
Copy link
Contributor Author

Sorry, I don't understand the problem here. Do you want a CI or a package for FreeBSD?
If I can help, let me know.

@lbartoletti
Copy link
Contributor Author

@dom96 I'll have some free time to chase nim (Free)BSD bugs and upgrade. How can I help you? Is this PR could be merged?

@dom96
Copy link
Owner

dom96 commented Dec 7, 2021

I think we can merge it, but yeah, you'll need to build choosenim yourself which kinda defeats the purpose :)

Unless you can get it into FreeBSD's package manager, that'd be cool

@dom96 dom96 merged commit 4ea8702 into dom96:master Dec 7, 2021
@lbartoletti
Copy link
Contributor Author

I think we can merge it, but yeah, you'll need to build choosenim yourself which kinda defeats the purpose :)

Unless you can get it into FreeBSD's package manager, that'd be cool

I'm FreeBSD ports (aka package) committer 😉 and I want to take some time to add some nim package 😉

Thanks @dom96

@lbartoletti lbartoletti deleted the freebsd_support branch December 7, 2021 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants