Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Puppy dep version #293

Merged
merged 1 commit into from
Jan 29, 2022
Merged

Update Puppy dep version #293

merged 1 commit into from
Jan 29, 2022

Conversation

guzba
Copy link
Contributor

@guzba guzba commented Jan 29, 2022

Related issue: #287

This PR updates Puppy's dep version. This does a few things:

  1. Lowers Puppy's minimum required Nim version to below that of choosenim, addressing issue Choosenim depends on Nim 1.4.4 #287
  2. I redid Puppy's internals for Windows a while back. It is better and I know choosenim uses Puppy on Windows so this is relevant.

There no changes to Puppy that necessitate any changes in choosenim.

dom96
dom96 approved these changes Jan 29, 2022
View reviewed changes
Copy link
Owner

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dom96 dom96 merged commit f609844 into dom96:master Jan 29, 2022
@4zv4l
Copy link

4zv4l commented Dec 8, 2023

I reopen this issue because I got this error when trying choosenim
image

And apparently Puppy 1.5.4 is over a year old (from the Nim discord when I asked what could cause the issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guzba @4zv4l @dom96