Fixes for 0.18.1

[genotrance]

Fixes for ""[0]

[dom96]

When writing code like this, instead of wrapping the code in an if, just write the following above the code:

if c.len() == 0:
  return

It's the same and it makes the code less messy.

[genotrance]

Updated.

[dom96]

This isn't a valid fix for whatever issue this fixes.

[genotrance]

This happens when running tests - there's no terminal available so eraseLine() raises OSError.

[dom96]

Then how have the tests worked before?

[genotrance]

Only Windows raises OSError, Linux does not so I can only guess that this wasn't tested on Windows before.

[dom96]

I don't see a reason to do this. Quoting everything is fine, and the code is much more succinct.

[genotrance]

Yes, but it is failing tests even on 0.18.0 since it is appending spaces or " to file paths for --nimbleDir or --choosenimDir which then no longer resolve as paths. It's easier fixing the tester than changing choosenim parseCliParams().

[dom96]

Again, how did this pass before?

[genotrance]

It didn't pass for me even on 0.18.0, I think it is probably because of running the tests on Windows. It never passed for me because the command line params were getting messed up.

[genotrance]

Verified tests pass on latest #head of Nim on both Windows and Linux. I require the patched untar without which the following error occurs.

 Extracting nim-0.16.0.tar.xz
       Tip: 1 messages have been suppressed, use --verbose to show them.
     Error: choosenim.nim(206)       choosenim
        ... choosenim.nim(187)       performAction
        ... choosenim.nim(89)        choose
        ... choosenim.nim(72)        chooseVersion
        ... choosenim.nim(39)        installVersion
        ... utils.nim(51)            extract
        ... Unable to extract. Error was 'invalid integer: '.

Invalid integer is raised by parseOctInt(). I'm checking to see if there were any code changes in that proc recently.