Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't import the newSettings function qualified #282

Closed
AjBreidenbach opened this issue Aug 25, 2021 · 1 comment
Closed

Can't import the newSettings function qualified #282

AjBreidenbach opened this issue Aug 25, 2021 · 1 comment

Comments

@AjBreidenbach
Copy link

AjBreidenbach commented Aug 25, 2021

The following code

import jester except newSettings, settings

router myRouter:
  get "/library":
    resp "library"

when isMainModule:

  let mySettings = jester.newSettings(
    port=Port(7000)
  )

  var jesterInstance = initJester(myRouter, mySettings)
  serve(jesterInstance)

fails to compile with

/tmp/test.nim(4, 8) template/generic instantiation of `router` from here
/home/andrew/projects/jester/jester.nim(831, 20) Error: undeclared identifier: 'newSettings'

The issue seems to be fixed with this commit AjBreidenbach@2c58c0e

@dom96
Copy link
Owner

dom96 commented Aug 25, 2021

can you make a PR? :)

dom96 added a commit that referenced this issue Oct 24, 2022
@dom96 dom96 closed this as completed in 9403126 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants