Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make setHeader public #293

Merged
merged 2 commits into from Jan 30, 2022
Merged

Make setHeader public #293

merged 2 commits into from Jan 30, 2022

Conversation

ajusa
Copy link
Contributor

@ajusa ajusa commented Jan 28, 2022

I had to write some pretty painful code to set a header before a redirect. 1 character change so no tests

@ajusa
Make setHeader public
f659c8d 
I had to write some pretty painful code to set a header before a redirect.
dom96
dom96 approved these changes Jan 30, 2022
View reviewed changes
Copy link
Owner

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add doc comment :)

@ajusa
Copy link
Contributor Author

ajusa commented Jan 30, 2022

Done!

@dom96 dom96 merged commit 2551a8c into dom96:master Jan 30, 2022
@dom96
Copy link
Owner

dom96 commented Jan 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajusa @dom96