Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.rst #1

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Update README.rst #1

merged 2 commits into from
Oct 10, 2018

Conversation

jindongwang
Copy link
Contributor

Nice work! I think when it comes to domain adaptation and transfer learning, you can't miss my repo: transferlearning.xyz.

Plus, my repo also contains some implementations that I would love to integrate to your repo. Can we do it together?

jindongwang and others added 2 commits October 10, 2018 09:37
Formatting and description
Copy link
Contributor

@stes stes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding your list and codebase! I will also have a look at your code and think of ways of best integrating it. Could you name some algorithms you think should also be added to salad ? Ideally, open an issue for that :)

@stes stes merged commit 8dce489 into domainadaptation:master Oct 10, 2018
@jindongwang
Copy link
Contributor Author

Good!
I think some popular unsupervised DA methods can also be added to salad. I can name a few: DaNN, DANN, DAN, JAN, SLN, etc. Too many of them. You can refer to the code directory in my repo.

@stes
Copy link
Contributor

stes commented Oct 13, 2018

Hi @jindongwang , fully agree that these approaches should be added. DANN is implemented, have a look at the salad.solver.da.DANNSolver. The implementation does not follow directly Ganin et al 2016, as it does not make use of the Gradient Reversal layer. However the layer itself is part of salad, so it is easy to use this method. Actually, VADA is an extension to DANN, so DANN is actually a part of the VADASolver ;-)

But I will have a look at your code and see how I can best integrate these methods! The goal is to keep extending salad until everything people refer to in papers is implemented :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants