Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OAuth 2 Authorization Code Flow with PKCE #999

Closed
fuzzzerd opened this issue Jan 4, 2019 · 13 comments · Fixed by #1405
Closed

Support OAuth 2 Authorization Code Flow with PKCE #999

fuzzzerd opened this issue Jan 4, 2019 · 13 comments · Fixed by #1405
Milestone

Comments

@fuzzzerd
Copy link

fuzzzerd commented Jan 4, 2019

Since there are now recommendations to avoid using Implicit flow and for (Authorization) code flow to be secure PKCE must be used it would be nice if the interface supported that.

More information here: https://brockallen.com/2019/01/03/the-state-of-the-implicit-flow-in-oauth2/

As well as a javascript client that does support it: https://github.com/IdentityModel/oidc-client-js/releases/tag/1.6.0

@poveilleux
Copy link

If I am not mistaken, this change needs to be done on the swagger-ui side before it can be integrated into Swashbuckle.AspNetCore. I opened the issue over there and I might give it a shot.

@domaindrivendev once it's done on the swagger-ui side, the only thing we need to do here is to bump up the version number for swagger-ui, right?

@poveilleux
Copy link

Now that the pull request on swagger-ui side is done, I will work on this side of the implementation as soon as I have the release including the changes for PKCE.

@fuzzzerd
Copy link
Author

fuzzzerd commented Oct 15, 2019

Looks like the PKCE feature was released: https://github.com/swagger-api/swagger-ui/releases/tag/v3.24.0!

Edit:
Looks like it was already patched in: ece92f8

Just waiting for the release!

@poveilleux
Copy link

Nice. I have a bit of a rush this week but I will try to make it work for next week!

@joaoquentalgomes
Copy link

Are there any developments on this subject? Thanks!

@poveilleux
Copy link

poveilleux commented Nov 12, 2019

I've been really busy for the last few weeks. I think I have a branch for this, I just need the time to test it and make sure it works.

@vgiannone3
Copy link

@poveilleux Hello! I am curious on the status of this request. When will it be available for use? I would like to secure my apps with this technique ASAP. Thanks!

@poveilleux
Copy link

@vgiannone3 Hello Vincent! As I said, I did not have time to work on it, but when I did the change on SwaggerUI's side, I also started a branch (see link above) to make the change. That should be it, I just did not have time to test it.

@vgiannone3
Copy link

Is there a way for us to consume using nuget?

@poveilleux
Copy link

Not yet, someone needs to make the change in Swashbuckle so it sets the PKCE property. Once this change is done and published, PKCE can be enabled when using Swashbuckle.

@vgiannone3
Copy link

Who would I have to contact to get that done?

@poveilleux
Copy link

You could fork Swashbuckle to your personal repositories, make the change and submit a pull request here

@vgiannone3
Copy link

Makes sense. Thanks for the help!

lurumad added a commit to lurumad/Swashbuckle.AspNetCore that referenced this issue Dec 2, 2019
@domaindrivendev domaindrivendev added this to the v5.0.0 milestone Jan 12, 2020
domaindrivendev added a commit that referenced this issue Jan 12, 2020
Add support to PKCE for SwaggerUI & update OAuth2Integration sample #999
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants