Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest version of Swagger UI to support Password Flow #986

Closed
pdusen opened this issue Jan 24, 2017 · 12 comments
Closed

Update to newest version of Swagger UI to support Password Flow #986

pdusen opened this issue Jan 24, 2017 · 12 comments

Comments

@pdusen
Copy link

pdusen commented Jan 24, 2017

Since #202 is closed and is not receiving any responses from @domaindrivendev, I'm trying to draw attention to this by opening a new issue.

Password Flow support has landed in swagger-ui Master: swagger-api/swagger-ui#2397

Please update Swashbuckle to make use of the newest version of swagger-ui.

@UnrealKazu
Copy link

Pull request #974 could be of interest for this issue. This essentially updates Swagger UI to 2.2.10, which has the new password flow functionality. I too am eager for this to be supported in Swashbuckle.

Though, I am not sure to what extend Swashbuckle itself would need some tinkering in order for password flow to function properly. This, as Swashbuckle provides config settings for the grant type which should be used in Swagger UI.

@aposashenko-distillery
Copy link

We're also interested in the password flow.

P.S. thank you guys for your work implementing so cool tool!

@VenomAV
Copy link

VenomAV commented May 3, 2017

I have just compiled the latest commit of master and I verified that OAuth2 password flow works correctly. Does anyone know when the new version of the NuGet package will be released?
The parameters of EnableOAuth2Support method are useless since the new version of Swagger UI does not use those configurations any more (at least for the password flow).

@heldersepu
Copy link
Contributor

It seem that the owner is busy with other projects...
But there is a call out for maintainers, see: #1053

@VenomAV
Copy link

VenomAV commented May 9, 2017

@heldersepu I saw the call for maintainers and I would like to be helpful. However, at the moment, I do not have enough insights on the inner workings of the library and the overall design to be of any real help.

@clabnet
Copy link

clabnet commented Jun 14, 2017

I am very interested to this update.

@Astimus
Copy link

Astimus commented Jun 14, 2017

I am very interested too. Authorization works great. But after there is no authorization header in requests to api. Is this will be solved after upgrade?

@heldersepu
Copy link
Contributor

All we need is a new version of the NuGet package...
Anyone in a rush I will recommend the solution from VenomAV: #986 (comment)

@heldersepu
Copy link
Contributor

I've been working on my fork, I updated to the latest Swagger-UI (3.x), here is how it looks on one of my projects:
http://turoapi.azurewebsites.net/swagger/ui/index

If you have time I could use your help testing it, you can get my version from MyGet:
https://www.myget.org/gallery/swashbuckle

@domaindrivendev
Copy link
Owner

domaindrivendev commented Jul 11, 2017

SB v5.6.0 ships with swagger-ui 2.2.10 and is now available on Nuget. I believe this resolves the original issue. @pdusen - please let me know if this isn't the case. Thanks

@UnrealKazu
Copy link

@domaindrivendev It seems like the way authorization settings are configured in Swagger UI have been changed. This means that the corresponding EnableOAuth2Support method is no longer working, like @VenomAV already mentioned.

So this isn't a clear-cut 'upgrade Swagger-UI and everything is fixed'-solution, unfortunately. It does seem that there isn't too much needed to make Swashbuckle work with those new settings, though.

@ai-fwd
Copy link

ai-fwd commented Sep 6, 2017

@UnrealKazu if possible can you elaborate on the changes required to make Swashbuckle work with the new settings so it's a little more turnkey for the rest of us? Using the V5.6 which ships with swagger-ui 2.2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants