Fix cli unit tests

cli/index.js

@@ -6,15 +6,15 @@ const domapic = require('domapic-base')
 const options = require('../lib/options')
 const user = require('./commands/user')
 
-domapic.cli({
+module.exports = domapic.cli({
   script: path.resolve(__dirname, '..', 'server.js'),
   customConfig: options,
   customCommands: {
     user
   }
-}).catch((err) => {
+}).catch(err => {
   process.exitCode = 1
   if (!err.isDomapic) {
-    console.log(err)
+    console.error(err)
   }
 })

package.json

@@ -30,7 +30,8 @@
     "coveralls": "3.0.2",
     "narval": "2.2.1",
     "request": "2.87.0",
-    "request-promise": "4.2.2"
+    "request-promise": "4.2.2",
+    "mockery": "2.1.0"
   },
   "author": {
     "name": "Javier Brea",

test/functional/specs/db-config.specs.js

@@ -10,7 +10,7 @@ test.describe('server', function () {
   test.it('should have printed a log with the mongodb uri', () => {
     return testUtils.logs.combined('controller')
       .then((log) => {
-        return test.expect(log).to.contain(`Connecting with database "${DB_URI}"`)
+        return test.expect(log).to.contain(`Connected to database "${DB_URI}"`)
       })
   })
 

test/unit/Base.mocks.js

@@ -29,7 +29,7 @@ const Mock = function () {
 
   const stubs = {
     service: serviceStubs,
-    cli: sandbox.stub(domapicBase, 'cli'),
+    cli: sandbox.stub(domapicBase, 'cli').usingPromise().resolves(),
     Service: sandbox.stub(domapicBase, 'Service').usingPromise().resolves(serviceStubs)
   }
 

test/unit/cli/index.specs.js

@@ -2,30 +2,101 @@
 const path = require('path')
 
 const test = require('narval')
+const mockery = require('mockery')
 
-const mocks = require('../mocks')
-
-const options = require('../../../lib/options')
-
-test.describe('cli index', () => {
+test.describe('cli index', function () {
+  this.timeout(10000)
+  let sandbox
   let baseMock
+  let consoleStub
+  let previousExitCode
+  let mocks
+  let options
+  let userCommand
+
   test.before(() => {
-    baseMock = new mocks.Base()
-    require('../../../cli/index')
+    mockery.enable({
+      useCleanCache: true,
+      warnOnReplace: false,
+      warnOnUnregistered: false
+    })
   })
 
   test.after(() => {
-    baseMock.restore()
+    mockery.deregisterAll()
+    mockery.disable()
   })
 
-  test.it('should called to create a cli from domapic base', () => {
-    test.expect(baseMock.stubs.cli).to.have.been.called()
+  test.describe('when cli execution finish ok', () => {
+    test.beforeEach(() => {
+      mockery.resetCache()
+      mocks = require('../mocks')
+      options = require('../../../lib/options')
+      userCommand = require('../../../cli/commands/user')
+      previousExitCode = process.exitCode
+      sandbox = test.sinon.createSandbox()
+      baseMock = new mocks.Base()
+      return require('../../../cli/index')
+    })
+
+    test.afterEach(() => {
+      process.exitCode = previousExitCode
+      baseMock.restore()
+      sandbox.restore()
+    })
+
+    test.it('should called to create a cli from domapic base', () => {
+      test.expect(baseMock.stubs.cli).to.have.been.called()
+    })
+
+    test.it('should have passed the server script path when created the cli', () => {
+      test.expect(baseMock.stubs.cli).to.have.been.calledWith({
+        script: path.resolve(__dirname, '..', '..', '..', 'server.js'),
+        customConfig: options,
+        customCommands: {
+          user: userCommand
+        }
+      })
+    })
   })
 
-  test.it('should have passed the server script path when created the cli', () => {
-    test.expect(baseMock.stubs.cli).to.have.been.calledWith({
-      script: path.resolve(__dirname, '..', '..', '..', 'server.js'),
-      customConfig: options
+  test.describe('when cli execution fails', () => {
+    test.afterEach(() => {
+      process.exitCode = previousExitCode
+      baseMock.restore()
+      sandbox.restore()
+    })
+
+    test.it('should trace not controlled errors if cli fails', () => {
+      const error = new Error('foo')
+
+      mockery.resetCache()
+      mocks = require('../mocks')
+      previousExitCode = process.exitCode
+      sandbox = test.sinon.createSandbox()
+      baseMock = new mocks.Base()
+      baseMock.stubs.cli.rejects(error)
+      consoleStub = sandbox.stub(console, 'error')
+      return require('../../../cli/index').then(() => {
+        return test.expect(consoleStub).to.have.been.calledWith(error)
+      })
+    })
+
+    test.it('should not trace controlled errors if cli fails', () => {
+      const error = new Error()
+      error.isDomapic = true
+
+      mockery.resetCache()
+      mocks = require('../mocks')
+      previousExitCode = process.exitCode
+      sandbox = test.sinon.createSandbox()
+      baseMock = new mocks.Base()
+      baseMock.stubs.cli.rejects(error)
+      consoleStub = sandbox.stub(console, 'error')
+
+      return require('../../../cli/index').then(() => {
+        return test.expect(consoleStub).to.not.have.been.called()
+      })
     })
   })
 })

test/unit/lib/Commands.specs.js

@@ -31,7 +31,8 @@ test.describe('Commands', () => {
         'getAll',
         'getById',
         'get',
-        'init'
+        'init',
+        'remove'
       )
     })