Api permissions and params #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javierbrea
commented
Sep 29, 2018
javierbrea
commented
- Change apiKey by camelcase in all code.
- Allow service-registerer users to get users with service role.
- Allow admin users to add apiKeys for any user.
- Add role filter to get users api.
- Use only ids as get params in apis.
- Allow service-registerer users to create apiKeys for service users
…e-registerer users to create apiKeys for services. Allow service-registerer users to read service users
…s to get users with service role. Allow admin users to add apiKeys for any user. Add role filter to get users api. Use only ids as get params in apis. Allow service-registerer users to create apiKeys for service users
Pull Request Test Coverage Report for Build 145
💛 - Coveralls |
Pull Request Test Coverage Report for Build 143
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.