Eliminate compile warnings #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While C99 does allow this, rake-compiler forces this warning on, thus disallowing mixed declarations and code.
In most cases this seemed to be copypasted code, using Data_Get_Struct where it wasn't needed.
Make the for-loop counter variable unsigned, since we're comparing to sizeof(), which always returns an unsigned value.
This allows us to see possible mistakes earlier, allowing for a stricter adherance to the C standard
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not behavioural changes, only cosmetic changes to eliminate compile-time warnings.
I'm doing these things as PRs rather than committing directly in hopes of somebody eyeballing my changes. If you don't have the time to do this at this point, I'll switch to simply committing my changes directly after testing.
Fixes #15