Provide access to wrenGetVariable() and wrenGetSlotHandle()
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wrenSetSlotNewForeign()` cannot be used for something other than foreign allocator if they are not provided.
|
Please add these to the documentation also. |
|
Didn't see that. |
ChayimFriedman2
force-pushed
the
add-get-variable-slot-handle
branch
2 times, most recently
from
aa5642a
to
92e0a63
Compare
ChayimFriedman2
force-pushed
the
add-get-variable-slot-handle
branch
from
92e0a63
to
84e953f
Compare
ChayimFriedman2
force-pushed
the
add-get-variable-slot-handle
branch
from
980022e
to
8a638e0
Compare
|
At this point, we should probably go through and add all the other relevant Wren VM functions which depend on the slot array:
And possibly others I missed? |
|
The methods in the PR are ones that I actually need in my plugin. Others can be useful too, I don't know. |
|
I guess they can wait for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrenSetSlotNewForeign()cannot be used for something other than foreign allocator if they are not provided.