Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the math library to use inbuilt functions #204

Merged
merged 4 commits into from
Jul 13, 2021

Conversation

TheKing0x9
Copy link
Contributor

This pull updates the Dome Math library to use the inbuilt functions for min, max and clamp., The changed functions are

  • Math.min (a, b)
  • Math.max(a, b)
  • Math.mid (a, b, c)

Also, a new function Math.clamp (number, min, max ) has been added which is a wrapper around the inbuilt Num.clamp function

Copy link
Collaborator

@avivbeeri avivbeeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. You just need to add Math.clamp to the documentation and this looks good to merge :)

Feel free to add yourself to the AUTHORS file also!

@avivbeeri avivbeeri linked an issue Jul 13, 2021 that may be closed by this pull request
@TheKing0x9
Copy link
Contributor Author

The documentation for Math.clamp has been added.

@avivbeeri avivbeeri merged commit aad7119 into domeengine:develop Jul 13, 2021
@avivbeeri
Copy link
Collaborator

Thank you so much!

@TheKing0x9 TheKing0x9 deleted the num-update branch February 17, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update math module to use new Num methods
2 participants