Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chai 4.0.1 is broken #198

Closed
reconbot opened this issue Jun 2, 2017 · 2 comments
Closed

Chai 4.0.1 is broken #198

reconbot opened this issue Jun 2, 2017 · 2 comments

Comments

@reconbot
Copy link

reconbot commented Jun 2, 2017

chai-as-promised seems to be broken with Chai 4.0.1. The assertions return some sort of internal object instead of a promise.

The promise object is a bluebird promise.

// assert.isRejected(Promise.reject(new Error('foo')))
overwritingMethodWrapper {
  __flags:
   { ssfi: [Function: proxyGetter],
     lockSsfi: undefined,
     object:
      Promise {
        _bitField: 16777216,
        _fulfillmentHandler0:
         Error: foo
             at Context.<anonymous> 
             // removed for brevity,
        _rejectionHandler0: undefined,
        _promise0: undefined,
        _receiver0: undefined,
        _trace: [Object] },
     message: undefined } }
@meeber
Copy link
Contributor

meeber commented Jun 2, 2017

@reconbot This is addressed in #157

All: Probably best we leave this issue open until that PR gets merged. Most people don't check closed issues or PRs before posting an issue.

@reconbot
Copy link
Author

reconbot commented Jun 2, 2017

Ahh thank you, I of course overlooked the PR.

igorshapiro added a commit to WiserSolutions/quadro that referenced this issue Jun 6, 2017
igorshapiro added a commit to WiserSolutions/quadro that referenced this issue Jun 6, 2017
igorshapiro added a commit to WiserSolutions/quadro that referenced this issue Jun 6, 2017
domenic pushed a commit that referenced this issue Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants