New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix getMethod #6
Conversation
Tests showing the difference? |
Added test. |
I can squash the commits if you'd like and if it is okay for merging. |
Can you test Get vs. GetV? |
Yes, but I just realized something odd. With this change, this test should not be passing anymore. Oh, that's because this assertion must be removed as well. |
PTAL. |
The only difference I see is that Get would throw an error for non-objects while GetV boxes them. |
Just to be sure, when you asked for Get vs. GetV, you actually mean [[Get]] vs. GetV? There's no observable change as mentioned above. |
Does this need anything else to be merged? @domenic |
No, it looks good. I just need to get some free time to merge and release, which is a bit tricky as I'm traveling for standards meetings the next two days. Maybe I can pull it off on this bus ride though... |
Merged as 523059e; 2.0.1 coming shortly. |
Thanks! |
Reference: https://people.mozilla.org/~jorendorff/es6-draft.html#sec-getmethod