Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on Q and return the same type of promise that was passed in #2

Merged
merged 1 commit into from Jul 30, 2013
Merged

Remove dependence on Q and return the same type of promise that was passed in #2

merged 1 commit into from Jul 30, 2013

Conversation

ForbesLindesay
Copy link
Contributor

I've wanted this module so many times. Thanks so much for actually writing it.

I'd like to use this as part of the real-time rendering feature of regexplained.co.uk once I finish getting it to work with web-workers, but I'd rather use a more bare bones promise implementation (and I'm biased towards my own).

I also love the idea of making utilities that are promise library agnostic, so here goes.

@domenic
Copy link
Owner

domenic commented Jul 30, 2013

Oh, wow, this is extremely clever. I thought I'd need to wait for Q to get a promise constructor---see #1---but this is even better. Thanks so much!

@domenic domenic merged commit 4f62bf3 into domenic:master Jul 30, 2013
@ForbesLindesay
Copy link
Contributor Author

I wish I could find a similar sollution for https://github.com/ForbesLindesay/throat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants