Mocha module detection #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recurse through the loaded modules and find mocha by its id property.
|
Merged as 9068209, and published as 1.4.0, thanks so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for loading mocha-as-promised when running outside of the mocha command line. Search modules starting at require.main to find the first module ending in mocha/lib/mocha.js, and assume that it is the running mocha module. Tested this technique on windows and linux, under grunt-mocha-test, grunt-mocha-hack and grunt-mocha-spawn. I'll keep trying to poke holes in the idea, but I think it should work.
PS thanks for mocha-as-promised, it cut lots of code out of our promise-based tests. Hopefully it makes its way into mocha someday. Have a good time at JSConf.