Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Tighten up event init dictionary definition
Closes #11. Since both places in the spec initialize both attributes immediately, and the dictionary contains required for promise and = null for reason, there is no need to specify in prose a default value for the attributes anymore.
- Loading branch information
463179c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@foolip do you remember why we added
required
here? It seems unusual for event init dicts.463179c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this doesn't ring any bells, and it does look odd given that it's nullable.
I vaguely remember something about
required
being a good idea when the dictionary argument itself is required, since a "required" argument that will accept just{}
as an argument is silly. However, that isn't the situation here.