Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated epub not compatible with Play Books #22

Closed
Es7evam opened this issue Dec 31, 2020 · 4 comments
Closed

Generated epub not compatible with Play Books #22

Es7evam opened this issue Dec 31, 2020 · 4 comments

Comments

@Es7evam
Copy link

Es7evam commented Dec 31, 2020

The generated epub is not compatible with Google Play Books.

An online epub validator (https://www.ebookit.com/tools/bp/Bo/eBookIt/epub-validator) points out possible errors. There are several on chapter 79, some on 211, 249 and 275.

Also it seems to have some problem on the cover and the img tag.

The only two fatal errors are on chapter 79, probably due some tag that was not closed properly:

FATAL(RSC-016): ./books/Bo/databases/eBookIt/temp_uploads/1609380837.epub/OEBPS/chapters/chapter079.xhtml(210,6): Fatal Error while parsing file: The element type "p" must be terminated by the matching end-tag "
".

ERROR(RSC-005): ./books/Bo/databases/eBookIt/temp_uploads/1609380837.epub/OEBPS/chapters/chapter079.xhtml(-1,-1): Error while parsing file: The element type "p" must be terminated by the matching end-tag "
". 
@domenic
Copy link
Owner

domenic commented Dec 31, 2020

Thank you for finding this! Worm, not Ward, I take it? I'll look into it ASAP.

@Es7evam
Copy link
Author

Es7evam commented Dec 31, 2020

Yes, worm.

I tested Ward just in case and it's much better, albeit not compatible as well.

There's one fatal error in chapter 214, the other ones are the same warnings (e.g. the cover one, which might be good to take a look at since it's missing a "type" attribute at the style tag that some readers might autocomplete but others might not)

The fatal error:

FATAL(RSC-016): ./books/Bo/databases/eBookIt/temp_uploads/1609423750.epub/OEBPS/chapters/chapter214.xhtml(325,133): Fatal Error while parsing file: The element type "p" must be terminated by the matching end-tag "

domenic added a commit that referenced this issue Dec 31, 2020
domenic added a commit that referenced this issue Dec 31, 2020
Noticed via the validation discussed in #22, which was failing on the draggable attribute.
domenic added a commit that referenced this issue Dec 31, 2020
domenic added a commit that referenced this issue Dec 31, 2020
Helps with the validation errors noted in #22.
domenic added a commit that referenced this issue Dec 31, 2020
This is the last error (for Worm) noted via epubcheck, per #22.
@domenic
Copy link
Owner

domenic commented Dec 31, 2020

OK, everything is passing the validator now! I'll see if I can get continuous integration running to prevent such problems in the future...

@Es7evam
Copy link
Author

Es7evam commented Dec 31, 2020

It's working perfectly now. Also tested on play books and both epubs are now now compatible with it.

Thanks for the quick fix!

domenic added a commit that referenced this issue Jan 1, 2021
This should help detect any issues such as those seen in #22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants