Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Reverse A-Trous Iterations #1

Open
alaingalvan opened this issue Feb 27, 2020 · 1 comment
Open

Suggestion: Reverse A-Trous Iterations #1

alaingalvan opened this issue Feb 27, 2020 · 1 comment

Comments

@alaingalvan
Copy link

Hi, great job on this demo! I did notice that there's some edge artifacts between the walls of the Cornell Box that may benefit from using a reverse A-trous iteration scheme (where you iterate from large to small) like in this tweet:

https://twitter.com/NateMorrical/status/1180302300549500928

Note how the walls of his Cornell box don't have edge artifacts.

This would involve changes here to this section of your project from what I can see here.

atrousMaterial.uniforms.uStep.value *= controller.stepMultiplier;

@Domenicobrz
Copy link
Owner

@alaingalvan First of all: thank you a lot for your article! I tried this little experiment after reading it, I had no hope of understanding the ideas behind the algorithm without it

If you cloned this repo recently, I just fixed a strange bug that ruined filtering across all edges on some gpus, whereas the live demo didn't had it

I've made a new branch where I'll experiment with the "reversed filter" in the next days, thank you :) or if you want to make a PR feel free to do so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants