Genesis, ChainID, and Context Configuration #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 9, 2021
Closed
alanorwick
changed the title
mechanikalk
requested changes
Aug 10, 2021
| case 6: | ||
| genesis = core.MainnetZoneGenesisBlock(params.MainnetZoneOneChainConfig) | ||
| case 7: | ||
| genesis = core.MainnetZoneGenesisBlock(params.MainnetZoneOneChainConfig) |
There was a problem hiding this comment.
@jdowning100 Fixed in #23
| }, | ||
| Threshold: 2, | ||
| } | ||
| MainnetCheckpointOracle = &CheckpointOracleConfig{} |
There was a problem hiding this comment.
please add a TODO here saying that we need to add checkpoint keys back in.
| @@ -316,6 +255,7 @@ type CheckpointOracleConfig struct { | |||
| type ChainConfig struct { | |||
| ChainID *big.Int `json:"chainId"` // chainId identifies the current chain and is used for replay protection | |||
|
|
|||
| Context int // Context defines the index in which the chain operates at | |||
| HomesteadBlock *big.Int `json:"homesteadBlock,omitempty"` // Homestead switch block (nil = no fork, 0 = already homestead) | |||
There was a problem hiding this comment.
We don't need to do this here, but we should make an issue to remove all of the forks that exist in ETH and make this a clean slate
There was a problem hiding this comment.
@mechanikalk yeah it'll be an issue that we need to flag
There was a problem hiding this comment.
would be best to do it all in one go
mechanikalk
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for writing genesis block based off of context.