Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Petx caching in Doms and Peer Location bucketing #885

Merged
merged 1 commit into from May 17, 2023

Conversation

gameofpointers
Copy link
Contributor

@dominant-strategies/core-dev

Copy link
Member

@wizeguyy wizeguyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the actual peer buckets. I don't see anywhere the peering library attempts to maintain buckets of peers for each location. We need that logic before this can merge.

eth/handler.go Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
eth/handler.go Show resolved Hide resolved
@wizeguyy
Copy link
Member

wizeguyy commented May 17, 2023

@gameofpointers the first commit cannot merge until we implement logic to maintain a minimum number of peers from each slice. The second commit can merge now as is, and provides an optimization to our peer requests. If you want to drop the first commit, then we can merge this PR. Otherwise we still need the peer bucket logic

@gameofpointers gameofpointers force-pushed the petx-cache branch 2 times, most recently from 129d92b to 2e0581d Compare May 17, 2023 14:34
@wizeguyy wizeguyy self-requested a review May 17, 2023 19:15
@gameofpointers gameofpointers merged commit 48cf1e1 into dominant-strategies:main May 17, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants