-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Blake3 to ProgPoW #963
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some more files to review, but left a couple minor (get it?) comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a general question. Why do we still have ethash in the code base and have made changes to it if we are not going to use it now
Progpow is Ethash. You can think of it as Ethash V2. Why does the file reference ethash? Because the ethereum devs wrote progpow as an extension of ethash and they documented it accordingly. Not sure what the hangup is here. |
@wizeguyy I meant blake3, didnt mean Ethash here |
7b9fd31
to
a58fb35
Compare
Hope that answers your question. |
59e8023
to
c77a7c8
Compare
@dominant-strategies/core-dev