Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Blake3 to ProgPoW #963

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Conversation

wizeguyy
Copy link
Member

@dominant-strategies/core-dev

@wizeguyy wizeguyy changed the title Switch to ProgPoW from Blake3 Switch to Blake3 to ProgPoW Jun 16, 2023
@wizeguyy wizeguyy changed the title Switch to Blake3 to ProgPoW Switch from Blake3 to ProgPoW Jun 16, 2023
Copy link
Contributor

@Djadih Djadih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some more files to review, but left a couple minor (get it?) comments.

core/core.go Show resolved Hide resolved
eth/api_backend.go Show resolved Hide resolved
internal/quaiapi/quai_api.go Show resolved Hide resolved
consensus/progpow/algorithm_progpow.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gameofpointers gameofpointers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a general question. Why do we still have ethash in the code base and have made changes to it if we are not going to use it now

core/types/gen_header_json.go Outdated Show resolved Hide resolved
core/types/gen_header_json.go Outdated Show resolved Hide resolved
eth/ethconfig/gen_config.go Show resolved Hide resolved
consensus/progpow/progpow.go Show resolved Hide resolved
consensus/progpow/progpow.go Show resolved Hide resolved
@wizeguyy
Copy link
Member Author

Why do we still have ethash in the code base and have made changes to it if we are not going to use it now

Progpow is Ethash. You can think of it as Ethash V2.

Why does the file reference ethash? Because the ethereum devs wrote progpow as an extension of ethash and they documented it accordingly. Not sure what the hangup is here.

go.mod Outdated Show resolved Hide resolved
@gameofpointers
Copy link
Contributor

@wizeguyy I meant blake3, didnt mean Ethash here I have a general question. Why do we still have ethash in the code base and have made changes to it if we are not going to use it now

@wizeguyy wizeguyy force-pushed the progpow branch 4 times, most recently from 7b9fd31 to a58fb35 Compare June 20, 2023 21:10
@wizeguyy
Copy link
Member Author

@wizeguyy I meant blake3, didnt mean Ethash here

  • changes were made to blake3, because the consensus interface had to change
  • The consensus interface had to change, because POEM needed to be moved into the consensus engine, and the interface needs to accommodate POEM now.
  • POEM had to move into the consensus engine, because Ethash/Progpow do not use block hash for PoW, so POEM could no longer operate on block hashes to calc intrinsic entropy. With POEM in block.go, all it had access to was the block hash.
  • Blake3pow was not removed from the codebase, because there has been discussion of scheduling a transition back to blake3. If we decide not to do any such transition, then it will be trivial to remove Blake3pow when the time comes.

Hope that answers your question.

@wizeguyy wizeguyy force-pushed the progpow branch 3 times, most recently from 59e8023 to c77a7c8 Compare June 21, 2023 16:08
@wizeguyy wizeguyy merged commit 4dfc811 into dominant-strategies:main Jun 21, 2023
0 of 2 checks passed
@wizeguyy wizeguyy temporarily deployed to quai-dev June 21, 2023 18:35 — with GitHub Actions Inactive
@wizeguyy wizeguyy deleted the progpow branch June 21, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants