Port WSL hack. Also needed for Crouton on chromebooks. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to make scuttlebot work on a Chromebook and with this hack it doesn't crash anymore. But it keeps connecting to the same nodes over and over again, so this "fix" might have some unexpected side effects. |
|
this seems reasonable. Is there another way we can detect onlineness on windows? |
|
merged into 0.0.1 since this is a zero range I think we'll need to update things which depend on this. |
|
Thanks. Seems like the connect is caused by frequent disconnects. I'll have to dig deeper but at least they are not directly related. I'll create a PR for updating the dependency in scuttlebot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/yarnpkg/yarn/blob/master/src/util/network.js#L9