New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port WSL hack. Also needed for Crouton on chromebooks. #1

Merged
merged 2 commits into from Dec 18, 2016

Conversation

Projects
None yet
2 participants
@arj03

This comment has been minimized.

Show comment
Hide comment
@arj03

arj03 Dec 18, 2016

Contributor

I'm trying to make scuttlebot work on a Chromebook and with this hack it doesn't crash anymore. But it keeps connecting to the same nodes over and over again, so this "fix" might have some unexpected side effects.

Contributor

arj03 commented Dec 18, 2016

I'm trying to make scuttlebot work on a Chromebook and with this hack it doesn't crash anymore. But it keeps connecting to the same nodes over and over again, so this "fix" might have some unexpected side effects.

@dominictarr

This comment has been minimized.

Show comment
Hide comment
@dominictarr

dominictarr Dec 18, 2016

Owner

this seems reasonable. Is there another way we can detect onlineness on windows?
will merge

Owner

dominictarr commented Dec 18, 2016

this seems reasonable. Is there another way we can detect onlineness on windows?
will merge

@dominictarr dominictarr merged commit 42d8c36 into dominictarr:master Dec 18, 2016

@dominictarr

This comment has been minimized.

Show comment
Hide comment
@dominictarr

dominictarr Dec 18, 2016

Owner

merged into 0.0.1 since this is a zero range I think we'll need to update things which depend on this.

Owner

dominictarr commented Dec 18, 2016

merged into 0.0.1 since this is a zero range I think we'll need to update things which depend on this.

@arj03

This comment has been minimized.

Show comment
Hide comment
@arj03

arj03 Dec 19, 2016

Contributor

Thanks. Seems like the connect is caused by frequent disconnects. I'll have to dig deeper but at least they are not directly related. I'll create a PR for updating the dependency in scuttlebot.

Contributor

arj03 commented Dec 19, 2016

Thanks. Seems like the connect is caused by frequent disconnects. I'll have to dig deeper but at least they are not directly related. I'll create a PR for updating the dependency in scuttlebot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment