failing test for json encoding #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i believe the last commit fixed this. each call to |
|
ack. i found another way to make this fail. more investigation is necessary. |
|
ah one place might be level-trigger I was debugging that recently and found that I had forgotten to support more than one encoding (it's hard coded to utf8) I wouldn't be surprised to see more things like this in old code... we'll fix all this in the new level-sublevel (which is coming along!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think this should work (it's a copy of the
replicate.jstest but with dbvalueEncodingset tojson). the error is[EncodingError: Unexpected token o]. not sure what's mangling the encoding internally. didn't we address this issue once before?