Skip to content
This repository has been archived by the owner on Nov 12, 2019. It is now read-only.

opts ignored #21

Closed
juliangruber opened this issue Nov 28, 2013 · 8 comments
Closed

opts ignored #21

juliangruber opened this issue Nov 28, 2013 · 8 comments

Comments

@juliangruber
Copy link
Collaborator

by @rvagg in #20 (comment):

here, opts will be assigned to a function if that's all that's supplied, it should be doing a typeof opts == 'object' before assuming that it's good to use

@juliangruber
Copy link
Collaborator Author

i fixed this in reconnect-core: juliangruber/reconnect-core@823cf0a

@dominictarr
Copy link
Owner

hey, @juliangruber, adding you to reconnect

@dominictarr
Copy link
Owner

lets make reconnect@2 just be reconnect-core, and just have one repo.
Okay, Ill have a look at this in the morning.

@juliangruber
Copy link
Collaborator Author

sweet!

@nrw
Copy link

nrw commented Feb 23, 2014

we might do well to move the examples over, too!

@dominictarr
Copy link
Owner

@nrw move the examples into reconnect-core?

by the way, this is now fixed and reconnect just depends on reconnect-core

@nrw
Copy link

nrw commented Feb 23, 2014

@dominictarr i now see that this just depends on reconnect-core. :)

regarding the examples: i think the reconnect-core repository would benefit from more examples. this repo has a few more. maybe i'm just advocating for a link in the reconnect-core readme to these examples.

@dominictarr
Copy link
Owner

agree - a link is the simplest way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants