Feature/#25 color wrapper fixes and additions #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domjancik
changed the title
|
thanks for contribution! |
dominicusmento
added a commit
that referenced
this pull request
Mar 14, 2020
* RGB color wrapper implemented, testing needed * Feature/#25 color wrapper fixes and additions (#38) * Changed X and Y incorrect string datatype to int * Implicit dimming for SetColor(device, r, g, b) * Updated docu for SetColor(id, x, y, intensity) * Separated Intensity calculation from RGB>XY conversion function * - changelog, readme and version updated - timeout lowerd for GenerateAppSecret, handling example added (TradfriUI, not the library itself) Co-authored-by: Tomidix <tomidix@gmail.com> Co-authored-by: Dominik Jančík <magnet.cz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some issues resulting in the X and Y based color functions not working.
Added a simple intensity calculation from RGB values to control dimming - maximum of the individual components. The components are expected to fall between 0 and 255.
This should result in colors as bright as possible and works well enough - tested with Tradfri color bulbs.
There are however other ways to approach this. For instance the eclipse/smarthome XY conversion includes the capital Y value in the brightness calculation. Maybe this results in more natural dimming curves but I'm not sure. It looks like the dimmer never goes full this way though. In any case it might be worth investigating.