unused: remove Object.Obj

lintcmd/runner/runner.go

@@ -1072,17 +1072,6 @@ func (r *subrunner) runAnalyzers(pkgAct *packageAction, pkg *loader.Package) (an
 			// TODO(dh): figure out a clean abstraction, instead of
 			// special-casing U1000.
 			unusedResult = a.Result.(unused.Result)
-
-			// Unset unused.Object.Obj, which is a types.Object, so that we can encode the rest with gob.
-			for i := range unusedResult.Used {
-				unusedResult.Used[i].Obj = nil
-			}
-			for i := range unusedResult.Unused {
-				unusedResult.Unused[i].Obj = nil
-			}
-			for i := range unusedResult.Quiet {
-				unusedResult.Quiet[i].Obj = nil
-			}
 		}
 
 		for key, fact := range a.ObjectFacts {

unused/unused.go

@@ -356,7 +356,6 @@ func (g *graph) objectToObject(obj types.Object) Object {
 		}
 	}
 	return Object{
-		Obj:             obj,
 		Name:            name,
 		ShortName:       obj.Name(),
 		Kind:            typString(obj),
@@ -1542,9 +1541,6 @@ func (g *SerializedGraph) color(rootID NodeID, states []nodeState) {
 }
 
 type Object struct {
-	// Obj is only populated for nodes that haven't been deserialized.
-	Obj types.Object
-
 	Name      string
 	ShortName string
 	// OPT(dh): use an enum for the kind